Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ET-5059 rename personalize to recommendations #1097

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

rustonaut
Copy link
Contributor

@rustonaut rustonaut commented Oct 5, 2023

Fully rename personalized_documents to recommendations in documentation (rust code still uses PersonalizedDocuments ans similar in some cases internally).

This now clearly separates the feature of finding recommendation and personalizing search. It also avoids issues like PersonalizedDocument not being a personalized document as we do not personalize the document. It's just part of a group of documents which order/choice of inclusion has been personalized. (It's also strictly speaking not a document but a snippet id and the scoring of the search for that snippet and optionally the properties of the document the snippet is from).

/users/{user_id}/personalized_documents => /users/{user_id}/recommendations

@github-actions github-actions bot added the work-in-progress The author is still working on this PR label Oct 5, 2023
@rustonaut rustonaut force-pushed the ET-5014-restructure-document branch from eb5dfa4 to 343af47 Compare October 5, 2023 15:57
@rustonaut rustonaut force-pushed the ET-5059-rename-personalize-to-recommendations branch from 5c21801 to 0ed10af Compare October 9, 2023 09:08
@rustonaut rustonaut marked this pull request as ready for review October 9, 2023 09:15
@github-actions github-actions bot added ready-for-review The PR can be reviewed and removed work-in-progress The author is still working on this PR labels Oct 9, 2023
web-api/openapi/front_office.yaml Show resolved Hide resolved
Base automatically changed from ET-5014-restructure-document to main October 12, 2023 12:27
@rustonaut rustonaut force-pushed the ET-5059-rename-personalize-to-recommendations branch from 862637a to e3f6ee8 Compare October 12, 2023 12:28
@rustonaut rustonaut enabled auto-merge October 12, 2023 12:56
@rustonaut rustonaut added this pull request to the merge queue Oct 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 12, 2023
@rustonaut rustonaut added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit e30f385 Oct 12, 2023
7 checks passed
@rustonaut rustonaut deleted the ET-5059-rename-personalize-to-recommendations branch October 12, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The PR can be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants