ET-5451 reduce probability of delete->insert race conditions #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustonaut
requested review from
joecks
and removed request for
janpetschexain
janpetschexain
force-pushed
the
ET-5451-reduce-probability-of-delete-insert-race-condition
branch
from
26cd490 to
65baf95
Compare
janpetschexain
approved these changes
Jan 16, 2024
janpetschexain
deleted the
ET-5451-reduce-probability-of-delete-insert-race-condition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete_by_parentfreshly_insert_documentto useindexinstead ofcreate, so it will replace existing documents with thesame ID, while
freshly_insert_documentis supposed to only be called with snippet ids not in elastic search there seems to be a race condition where this isn't the case, maybe related todelete_by_parent