[Merged by Bors] - rustfmt groups imports #660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
work-in-progress
|
looks good imo as it helps with consistency and readability.
that's not perfect, but more like a minor inconvenience.
it's anyway more clear to use |
acrrd
force-pushed
the
rustfmt_group_imports
branch
from
aa782ed to
45a82b1
Compare
github-actions
bot
added
ready-for-review
|
bors merge |
self-hosted-bors bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
This enables the `group_imports` option. With this rustfmt automatically groups the imports in `std`, `external`, and `crate.
This is almost what we already wanted but we lose control of some things:
* it is not able to differentiate between workspace and external so all our crates will go in that section,
* it does not understand local import:
```rust
mod foo {
struct Foo;
}
use foo::Foo;
use rand::random;
```
instead of having a separate group for `foo`.
* It does not respect groups that we create manually
```rust
use tokio;
use itertools;
```
the imports will be merged.
Looking at the changeset we are not too bad at maintaining this style. Most of the changes are the position of `crate` wr.t. to `self` or `super`, fusing groups, and moving our workspace crates to the external one.
But this will be our only option to enforce this style with a tool.
https://rust-lang.github.io/rustfmt/?version=v1.5.1&search=#group_imports
rust-lang/rustfmt#4709
rust-lang/rustfmt#4693
|
Pull request successfully merged into main. Build succeeded: |
self-hosted-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
group_importsoption. With this rustfmt automatically groups the imports instd,external, and `crate.This is almost what we already wanted but we lose control of some things:
instead of having a separate group for
foo.the imports will be merged.
Looking at the changeset we are not too bad at maintaining this style. Most of the changes are the position of
cratewr.t. toselforsuper, fusing groups, and moving our workspace crates to the external one.But this will be our only option to enforce this style with a tool.
https://rust-lang.github.io/rustfmt/?version=v1.5.1&search=#group_imports
rust-lang/rustfmt#4709
rust-lang/rustfmt#4693