Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when call_user_func is invoked inside an internal function #120

Closed
wants to merge 2 commits into from
Closed

Fix when call_user_func is invoked inside an internal function #120

wants to merge 2 commits into from

Conversation

phalcon
Copy link

@phalcon phalcon commented Sep 2, 2014

When the PHP userland function call_user_func is called inside an internal function/method, Xdebug cannot properly create the function name in xdebug_build_fname

@derickr
Copy link
Contributor

derickr commented Sep 3, 2014

Hi, I will check whether the code works in a bit, but in the meanwhile:

  • Can you file a bug at http://bugs.xdebug.org — if it is not the same as http://bugs.xdebug.org/view.php?id=1073 (I have an inkling it is related)
  • Add a test case, they're in .phpt format in the tests/ directory. Please name it according to the new bug number?
  • Can you exclude whitespace changes from your patch?

@vladimmi
Copy link

Any progress on this? Should phalcon developers fix something or you can do it yourself? This is pretty annoying bug (leaving developers without debugger as server segfaults) and 15 days without any activity is not good...

@derickr
Copy link
Contributor

derickr commented Sep 18, 2014

I've asked the PR submitter to clean up his patch. I am waiting for that to happen.

@phalcon
Copy link
Author

phalcon commented Sep 24, 2014

Sorry for the late reply, I've restored the whitespace and created a bug in Mantis. http://bugs.xdebug.org/view.php?id=1075

I'm not sure how I can add a test for this issue, since this only happens when call_user_func is called from an internal method (not from php userspace).

@derickr
Copy link
Contributor

derickr commented Oct 5, 2014

I've had a look, and I think that it is the same as http://bugs.xdebug.org/view.php?id=1073

The patch itself is not adequate for issue #1073 either, as it only allows for one level of call_user_func "inception". But I think that the I've just pushed a PR that makes both http://bugs.xdebug.org/view.php?id=1073 and http://bugs.xdebug.org/view.php?id=1075 go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants