Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue with capture_output=True on Python 3.6 #352

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

xen0l
Copy link
Owner

@xen0l xen0l commented Apr 17, 2020

No description provided.

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #352   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          838       840    +2     
=========================================
+ Hits           838       840    +2     
Impacted Files Coverage Δ
aws_gate/bootstrap.py 100.00% <100.00%> (ø)
aws_gate/decorators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef17fc...0654128. Read the comment docs.

@larryon
Copy link

larryon commented Apr 21, 2020

tested on Python 3.6.9 and it's working fine

@xen0l xen0l merged commit 6df6d85 into master Apr 21, 2020
@xen0l xen0l deleted the py36_compat branch April 21, 2020 12:39
@xen0l
Copy link
Owner Author

xen0l commented Apr 21, 2020

@larryon thanks for confirmation, I will release this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants