Added LoggingAwareExecuter interface to AnnotationBasedActionExecuter…

[tom-vandepoele]

… so exceptions in alfresco actions get handled the same as in ActionExecuterAbstractBase and not throw a java.lang.ClassCastException

Motivation and Context

When Alfresco's ActionServiceImpl method onLogException is called it tries to use the LoggingAwareExecuter interface, however it is not implemented so a java.lang.ClassCastException is thrown instead.
By simply adding the interface to the AnnotationBasedActionExecuter with the same implementation as in ActionExecuterAbstractBase this problem is resolved and error logging is handled as normal in OOTB alfresco action.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have updated the changelog.

[tom-vandepoele]

Specifically detected this issue when a mandatory action parameter was not filled in. (triggering the onLogException in the org.alfresco.repo.action.ActionServiceImpl

Very easy to reproduce, just set a mandatory parameter and call the action without setting it.

When debugging the ActionServiceImpl I could see the real exception was:

org.alfresco.service.cmr.rule.RuleServiceException: 01100058 Parameter 'namen' is mandatory, but no value was given.

but instead the logging said:

java.lang.ClassCastException: com.github.dynamicextensionsalfresco.actions.AnnotationBasedActionExecuter cannot be cast to org.alfresco.repo.action.executer.LoggingAwareExecuter

[kerkhofsd]

Thanks for your PR, @tom-vandepoele !

Related issue: #278

The problem is that the LoggingAwareExecuter doesn't exist on Alfresco 5.0, which means this would break compatibility.

[tgeens]

Can we polyfill that LoggingAwareExecuter on Alfresco 5.0 ?

[tom-vandepoele]

If you were to include the interface source in the annotation runtime package, I think this resolves the problem. Alfresco 5 would not have any runtime problems as the interface exists and later versions would work too.

[kerkhofsd]

To make sure this doesn't get lost I rebased on the latest master.

@tom-vandepoele

If you were to include the interface source in the annotation runtime package, I think this resolves the problem. Alfresco 5 would not have any runtime problems as the interface exists and later versions would work too.

If we include the LoggingAwareExecuter in e.g. annotations-runtime, this will result in LinkageErrors for the Alfresco versions that already contain this interface...

I think we have two options:

1. Drop 5.0 support, we could just include this fix AS-IS
2. Setup a mechanisme / submodule with the 'LoggingAwareExecuter' interface that is only include in Alfresco 5.0.

[kerkhofsd]

Decision concerning this issue:

• For DE 2.0, we introduce a LoggingAwareExecuter polyfill
• For DE 2.1, we can drop Alfresco 5.0 support & hence also the polyfill.

I rebased the branch once again on master & include the polyfill for Alfresco 5.0

[tgeens]

Looks good to me, but the sonar check fails ?

[kerkhofsd]

Sonar fails because:
> You're not authorized to run analysis. Please contact the project administrator.

I suppose this is because it's build from the tom-vandepoele remote?
-> merging

[kerkhofsd]

Thanks for the contribution @tom-vandepoele !