[FEATURE] Editable measurements #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalDybizbanskiCreoox
changed the title
xeolabs
requested changes
Jun 19, 2024
src/plugins/lib/ui/index.js
Outdated
| vec[1] += fromRec.top - toRec.top; | ||
| }; | ||
|
|
||
| export function draggableDot3D(handleMouseEvents, handleTouchEvents, viewer, worldPos, color, ray2WorldPos, onStart, onMove, onEnd) { |
There was a problem hiding this comment.
Could we please rename to createDraggableDot3D and use a parameter object (we try to avoid long argument lists just for style)
There was a problem hiding this comment.
Implemented by 72afa78
src/plugins/lib/ui/index.js
Outdated
| }; | ||
| }; | ||
|
|
||
| export function activateDraggableDots(viewer, handleMouseEvents, handleTouchEvents, snapping, pointerLens, color, markers, onEdit) { |
There was a problem hiding this comment.
Could we please use a parameter object here as well
There was a problem hiding this comment.
Implemented by 76590e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces components that enable users to interactively edit angle and distance measurements using both mouse and touch input.
Demos
The examples below showcase this feature using mouse input for both angle and distance measurements. Although not depicted here, editing is also supported for touch input.
In these examples, after creating a measurement, right-click on it to open a context menu, then select "Edit" to start editing.
Click and drag the measurement's endpoints to reposition them.
When you're done editing, right-click away from the measurement to open a context menu, then select "End Editing".
Distance measurement example
Angle measurement example