Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.sqlite.SQLiteConfig.setDatePrecision(String) throws unnecessary SQLException #467

Closed
michael-o opened this issue Dec 13, 2019 · 1 comment · Fixed by #751
Closed

org.sqlite.SQLiteConfig.setDatePrecision(String) throws unnecessary SQLException #467

michael-o opened this issue Dec 13, 2019 · 1 comment · Fixed by #751
Labels
enhancement

Comments

@michael-o
Copy link
Contributor

The signature is public void setDatePrecision(String datePrecision) throws SQLException, but at no point in the code a SQLException is thrown.
This just adds unnecessary boilerplate code. Please remove.
@gotson
Copy link
Collaborator

gotson commented Jul 27, 2022

@michael-o please send a PR if this is still an issue for you.

@gotson gotson added the waiting for feedback Waiting for a feedback from the issue creator label Jul 27, 2022
@michael-o michael-o mentioned this issue Jul 27, 2022
Merged
gotson pushed a commit that referenced this issue Jul 28, 2022
@michael-o
org.sqlite.SQLiteConfig.setDatePrecision(String) throws unnecessary S… (
14d5903 
#751)

Closes: #467
@gotson gotson added enhancement and removed waiting for feedback Waiting for a feedback from the issue creator labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

org.sqlite.SQLiteConfig.setDatePrecision(String) throws unnecessary S…
2 participants
@michael-o @gotson