-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow correct recognition of Android OS when running Termux environment #796
Conversation
why did you change some of the native libraries ? |
when running |
While working on #797 i am actually not sure how Termux works on Android.
Would you be able to check the value of the property |
Note: to install Java on Termux you run |
Thanks, that confirm my understanding. |
This still requires some work @arch-dev as there are conflicts, and the native libs should not have been changed. Is that something you're still working on? |
Reworked and used available |
@arch-dev i have refactored the code slightly and added some tests, please have a look and let me know if that's fine with you |
Yes good idea separing checks. Tested and it works without problems. |
If
isAndroid()
check fails,checkIfAndroidTermux()
is called which runsuname -o
command and check if its output containsandroid
. This should fix #789.Sample command output in Termux before changes:
Sample command output in Termux after changes: