Add zero padding to derived privkeys. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #74 +/- ##
========================================
Coverage 65.82% 65.82%
========================================
Files 40 40
Lines 2894 2894
Branches 401 401
========================================
Hits 1905 1905
Misses 920 920
Partials 69 69Continue to review full report at Codecov.
|
|
Good work .. thanks! |
xeroc
added a commit
that referenced
this pull request
Feb 6, 2019
Release 1.1.10 bdbd2e7 (HEAD -> master) Merge branch 'release/1.1.10' 26a9d8d (release/1.1.10) version bump 6226dab (develop) This way, we ensure that blockchain is instanciated properly 7b95f0a operations are empty in case we build proposals, hence, sign first b804252 Properly deal with claiming genesis balances 48ee6b9 (origin/develop) More details in case of Base58 erro and allow loading of keys in set bfb1b23 Merge pull request #74 from jhtitor/privkey_child_pad 50eae60 Merge tag '1.1.9' into develop 4db3d15 Add zero padding to derived privkeys.
hey, i think your citadel node is a couple of days out of sync, please check, thank you (sorry, i could not find another way to contact you) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've randomly encounted a privkey + offset combo that provide a 63-byte secret value (instead of expected 64). Looking at the code, there's nothing to guarantee secp values will be large enough, so some padding is necessary.