Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close role category change dialog after save then refresh parent #3921

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

Ryanseanlee
Copy link
Contributor

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@Ryanseanlee Ryanseanlee requested a review from amcclain February 19, 2025 22:04
@Ryanseanlee Ryanseanlee changed the title Close dialog after save then refresh parent Close role category change dialog after save then refresh parent Feb 19, 2025
@amcclain amcclain linked an issue Feb 21, 2025 that may be closed by this pull request
@amcclain amcclain merged commit cae4758 into develop Feb 21, 2025
2 checks passed
@amcclain amcclain deleted the roleCategoryChangeDialogUX branch February 21, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Role admin "Change Category" dialog should mask while saving
2 participants