Update corpus.py #102
Merged
Update corpus.py #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue with non-ASCII and UTF-8 characters was partially resolved by updating a single open() call within the find_newline_positions function to include encoding='utf-8'. This update ensures proper handling of multilingual text for the specific operation. However, it is recommended to review and update all instances of open() across the codebase to include encoding='utf-8' for consistency and to prevent similar issues in other functions.
|
can we make encoding a parameter of the function and set it to utf by default? |
|
sure, I've already made the changes. please check again |
|
Thank you! Will merge once tests pass |
xhluca
approved these changes
Jan 15, 2025
|
@Restodecoca i made a pre-release, can you confirm it works well for you? https://github.com/xhluca/bm25s/releases/tag/0.2.7pre3 |
|
sure, as soon as I can, I will return to you with feedback. |
|
bm25s==0.2.7pre3 |
|
Awesome! Will do an official release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with non-ASCII and UTF-8 characters was partially resolved by updating a single open() call within the find_newline_positions function to include encoding='utf-8'. This update ensures proper handling of multilingual text for the specific operation. However, it is recommended to review and update all instances of open() across the codebase to include encoding='utf-8' for consistency and to prevent similar issues in other functions.