Skip to content

Commit

Permalink
remove apparently redundant and deprecated gl alignment parameter set…
Browse files Browse the repository at this point in the history
…ting.
  • Loading branch information
xinaesthete committed Sep 30, 2024
1 parent d6aaeb8 commit 7a1dd44
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions packages/layers/src/xr-layer/xr-layer.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,16 +90,6 @@ const XRLayer = class extends Layer {
* This function initializes the internal state.
*/
initializeState() {
const { device } = this.context;
// This tells WebGL how to read row data from the texture. For example, the default here is 4 (i.e for RGBA, one byte per channel) so
// each row of data is expected to be a multiple of 4. This setting (i.e 1) allows us to have non-multiple-of-4 row sizes. For example, for 2 byte (16 bit data),
// we could use 2 as the value and it would still work, but 1 also works fine (and is more flexible for 8 bit - 1 byte - textures as well).
// https://stackoverflow.com/questions/42789896/webgl-error-arraybuffer-not-big-enough-for-request-in-case-of-gl-luminance
// -- this is now applying relevant parameters, but not helping with the rendering...
device.setParametersWebGL({
[GL.UNPACK_ALIGNMENT]: 1,
[GL.PACK_ALIGNMENT]: 1
});
const attributeManager = this.getAttributeManager();
attributeManager.add({
positions: {
Expand Down

0 comments on commit 7a1dd44

Please sign in to comment.