Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsapi update ci #2480

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Jsapi update ci #2480

merged 2 commits into from
Aug 5, 2020

Conversation

Urhengulas
Copy link
Contributor

@Urhengulas Urhengulas commented Aug 3, 2020

This PR has two purposes:

  • basic checking of the javascript in rav1e_js/www/
  • prepare for a continuous deployment of the rav1e_js example website

Changes

  • Upload artifact 'rav1e_js-pkg'
  • Install and build javascript
  • Fix wasm-pack test --headless --firefox

@Urhengulas Urhengulas requested a review from Luni-4 August 3, 2020 21:59
@coveralls
Copy link
Collaborator

coveralls commented Aug 3, 2020

Coverage Status

Coverage remained the same at 80.736% when pulling 40dcef5 on Urhengulas:jsapi-update-ci into d41b11a on xiph:master.

@Urhengulas Urhengulas self-assigned this Aug 3, 2020
@Urhengulas Urhengulas added the CI CI Related issues label Aug 3, 2020
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me too :)

Perhaps we could convert the deploy job in a new configuration of the build-pack-test job, called deploy, in this way it isn't necessary to upload/download artifacts. What do you think?

Does the deploy job need to be run for pull_request events also? If not, we need to move the entire job in a new yml file.

@Urhengulas
Copy link
Contributor Author

Urhengulas commented Aug 4, 2020

Seems good to me too :)

Perhaps we could convert the deploy job in a new configuration of the build-pack-test job, called deploy, in this way it isn't necessary to upload/download artifacts. What do you think?

Does the deploy job need to be run for pull_request events also? If not, we need to move the entire job in a new yml file.

The thing is, though it is called "deploy" it also does linting for js, which is also useful on PRs. But you are probably right, that this should be a configuration of the other job :)

Will refactor it.

@Luni-4
Copy link
Collaborator

Luni-4 commented Aug 4, 2020

The thing is, though it is called "deploy" it also does linting for js, which is also useful on PRs. But you are probably right, that this should be a configuration of the other job :)

I see, so let's convert it in a configuration :)

@Urhengulas Urhengulas force-pushed the jsapi-update-ci branch 2 times, most recently from c1e719f to 7d5ad4d Compare August 5, 2020 13:57

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Urhengulas Johann Hemmann
@Urhengulas
Copy link
Contributor Author

I've decided to add the yarn install && yarn build to the "build" configuration, because to run yarn we need to build the wasm before anyways.

Additionally I also fixed wasm-pack test --headless --firefox (rustwasm/wasm-bindgen#2261).

@Urhengulas Urhengulas requested review from lu-zero and Luni-4 August 5, 2020 14:58
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it, @Luni-4 do you agree?

Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just two nits :)

@Urhengulas Urhengulas requested a review from Luni-4 August 5, 2020 15:31
@Urhengulas Urhengulas force-pushed the jsapi-update-ci branch 2 times, most recently from abd07ec to 0ca69e2 Compare August 5, 2020 15:36

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Urhengulas Johann Hemmann
Copy link
Collaborator

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me now, thanks!

@Urhengulas
Copy link
Contributor Author

Seems good to me now, thanks!

Thanks for the review :P

@Luni-4
Copy link
Collaborator

Luni-4 commented Aug 5, 2020

Thanks for the review :P

Thanks to you for your work! :P

@vibhoothi vibhoothi merged commit f6ac395 into xiph:master Aug 5, 2020
@Urhengulas Urhengulas deleted the jsapi-update-ci branch August 5, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI Related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants