Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MIDI chord command (MCH) #314

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Add MIDI chord command (MCH) #314

merged 3 commits into from
Jan 15, 2025

Conversation

maks
Copy link
Collaborator

@maks maks commented Jan 14, 2025

Fixes: #184

@maks maks requested a review from democloid January 14, 2025 06:52
democloid
democloid reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@democloid democloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maks I'm afraid I either don't understand what this is trying to do or the code doesn't do what I expect.
I'd expect this to be a displacement from an original note on the sequencer, let's discuss it.

@maks
fix help legend for midi chord cmd
7fff021 
also fix clearing 1st for help legend otherwise midi instrument name
partials obscures help legend text
@maks maks merged commit 3103fa6 into master Jan 15, 2025
3 checks passed
@maks maks deleted the 184-midi-chords-cmd branch January 15, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@democloid democloid democloid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow sending chords through MIDI
2 participants
@maks @democloid