Check for instrument type change before releasing current instrument #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also remove macro instrument type from enum list to prevent future confusion on it not yet being shipped.
democloid
approved these changes
Feb 5, 2025
| @@ -9,10 +9,11 @@ | |||
|
|
|||
| #include "Application/Player/TablePlayback.h" | |||
|
|
|||
| const u_char INSTRUMENT_TYPES_COUNT = 5; | |||
There was a problem hiding this comment.
Isn't it better to have
enum InstrumentType { IT_NONE=0, IT_SAMPLE, IT_MIDI, IT_SID, IT_OPAL, IT_LAST };
and use IT_LAST as the count? (I'd remove macro for the moment
There was a problem hiding this comment.
yes thats a neat way to do it 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to check if the instrument type actually changed due to UI event (key combo) trying to trigger an instrument type change before we actually try to release the current instrument object.
Also quick clean up to remove macro instrument type from enum list to prevent future confusion on it not yet being shipped.
Fixes: #328