This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Xi py preparation #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e highest supported.
…x, publish counter)
…is the certs one-by-one the other was a list of these (this is deleted)
* master: [feat] added pi estimation for pub demo [fix] added .gitignore for tmp files and folders [feat] added separate version for pub and sub operations # Conflicts: # .gitignore
…acks (like on_connect_finish)
Exception:
File "/Users/atigyi/git/xi/xc/xively-getting-started/xi_client/xively_callback_handler.py", line 46, in on_message_received
self.delegate.on_message_received(self.delegate, message)
TypeError: on_message_received() takes 2 positional arguments but 3 were given
This was because default callbacks were member function but callbacks set by user are probably standalone function. The difference is the first argument: "self". In case of a member function python automagically adds a first "self" attribute for standalone functions doesn't. Thus for e.g. default on_connect_finish callback there were three arguments: self, client, result instead of 2.
Solved with modifying default callbacks to be @staticmethods.
* master: [forward] forwarded changes from xively client repository [fix] added join function call in case Py2 used # Conflicts: # xi_client/xively_client.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ JIRA ]
Release the Python Library
https://jira.3amlabs.net/browse/XB-27
[ Reviewer ]
[ Description ]
removing features before xiPy release:
[ QA ]
Conforms to writings in https://github.com/xively/xiPy-deprecated and in http://developer.xively.com/tutorials/pub-and-sub-from-python/
[ Release Notes ]