[BugFix] Fix ipv4 address parsing regression (vllm-project#3645)

xjpang · Mar 31, 2024 · fb51366 · fb51366
1 parent 6989b20
commit fb51366
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/vllm/utils.py b/vllm/utils.py
@@ -205,7 +205,9 @@ def get_ip() -> str:
 
 
 def get_distributed_init_method(ip: str, port: int) -> str:
-    return f"tcp://[{ip}]:{port}"
+    # Brackets are not permitted in ipv4 addresses,
+    # see https://github.com/python/cpython/issues/103848
+    return f"tcp://[{ip}]:{port}" if ":" in ip else f"tcp://{ip}:{port}"
 
 
 def get_open_port() -> int: