Skip to content

Commit

Permalink
s390x: Fix sclp console input
Browse files Browse the repository at this point in the history
When injecting an sclp console interrupt into the guest, we increase
the PC by 4 for some reason. I have no idea why I put that code there,
but it's clearly wrong. Remove the increment.

This patch fixes sclp serial input for the ccw machine.

Signed-off-by: Alexander Graf <[email protected]>
Reviewed-by: Bastian Koppelmann <[email protected]>
  • Loading branch information
agraf committed Nov 5, 2014
1 parent d5b4dc3 commit d482735
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions target-s390x/interrupt.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ void s390_sclp_extint(uint32_t parm)
kvm_s390_service_interrupt(parm);
} else {
S390CPU *dummy_cpu = s390_cpu_addr2state(0);
CPUS390XState *env = &dummy_cpu->env;

env->psw.addr += 4;
cpu_inject_ext(dummy_cpu, EXT_SERVICE, parm, 0);
}
}
Expand Down

0 comments on commit d482735

Please sign in to comment.