Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update glfw3webgpu to v1.2.0 #3935

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

waruqi
Copy link
Member

@waruqi waruqi commented May 3, 2024

New version of glfw3webgpu detected (package version: nil, last github version: v1.2.0)

@waruqi waruqi added the auto-update Automatic update label May 3, 2024
@SirLynix
Copy link
Member

SirLynix commented May 3, 2024

finding libx11 from xmake ..
error: @programdir/modules/package/manager/xmake/find_package.lua:137: wrong number of arguments to 'insert'
stack traceback:
    [C]: in function 'insert'
    [@programdir/modules/package/manager/xmake/find_package.lua:137]: in function '_find_package_from_repo'
    [@programdir/modules/package/manager/xmake/find_package.lua:350]:
    [@programdir/modules/package/manager/find_package.lua:110]: in function '_find_package'
    [@programdir/modules/package/manager/find_package.lua:194]:
    [@programdir/modules/lib/detect/find_package.lua:109]:
    [@programdir/core/package/package.lua:1794]: in function '_fetch_library'
    [@programdir/core/package/package.lua:1947]: in function 'fetch'
    [.../modules/private/action/require/impl/actions/install.lua:426]:

  => install libx11 1.8.7 .. failed
error: @programdir/core/main.lua:329: @programdir/modules/async/runjobs.lua:322: .../modules/private/action/require/impl/actions/install.lua:506: install failed!
stack traceback:
    [C]: in function 'error'
    [@programdir/core/base/os.lua:973]:
    [.../modules/private/action/require/impl/actions/install.lua:506]: in function 'catch'
    [@programdir/core/sandbox/modules/try.lua:123]: in function 'try'
    [.../modules/private/action/require/impl/actions/install.lua:370]:
    [...modules/private/action/require/impl/install_packages.lua:487]: in function 'jobfunc'
    [@programdir/modules/async/runjobs.lua:238]:

🤔

@waruqi
Copy link
Member Author

waruqi commented May 3, 2024

maybe this patch break it. https://github.com/xmake-io/xmake/pull/5023/files

libfoo.so.1 -> target.linkname return nil.

But I have no time to debug it in these days.

@SirLynix
Copy link
Member

SirLynix commented May 3, 2024

the issue is that the function doesn't return a value anymore, which is not the same as returning nil.

Example:

function foo()
  return nil
end

function bar()
end

local t = {}
print("inserting nil")
table.insert(t, foo()) -- ok
print("inserting nothing")
table.insert(t, bar()) -- error: wrong number of arguments
inserting nil
inserting nothing

lua5.3: Main.lua:12: wrong number of arguments to 'insert'
stack traceback:
	[C]: in function 'table.insert'
	Main.lua:12: in main chunk
	[C]: in ?

https://onecompiler.com/lua/42c5eryhc

I will make a PR to fix it

@waruqi
Copy link
Member Author

waruqi commented May 4, 2024

the issue is that the function doesn't return a value anymore, which is not the same as returning nil.

Example:

function foo()
  return nil
end

function bar()
end

local t = {}
print("inserting nil")
table.insert(t, foo()) -- ok
print("inserting nothing")
table.insert(t, bar()) -- error: wrong number of arguments
inserting nil
inserting nothing

lua5.3: Main.lua:12: wrong number of arguments to 'insert'
stack traceback:
	[C]: in function 'table.insert'
	Main.lua:12: in main chunk
	[C]: in ?

https://onecompiler.com/lua/42c5eryhc

I will make a PR to fix it

thanks.

@waruqi waruqi closed this May 4, 2024
@waruqi waruqi reopened this May 4, 2024
@waruqi waruqi merged commit accb6e2 into dev May 4, 2024
120 of 130 checks passed
@waruqi waruqi deleted the autoupdate-glfw3webgpu-v1.2.0 branch May 4, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Automatic update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants