Skip to content

Commit

Permalink
revert to MT
Browse files Browse the repository at this point in the history
  • Loading branch information
waruqi committed Jan 10, 2025
1 parent b0b094f commit e470863
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion core/src/tbox/tbox
Submodule tbox updated 1 files
+2 −2 xmake.lua
2 changes: 1 addition & 1 deletion core/xmake.lua
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ end]]

-- for the windows platform (msvc)
if is_plat("windows") then
set_runtimes("MD")
set_runtimes("MT")
add_links("kernel32", "user32", "gdi32")
end

Expand Down

2 comments on commit e470863

@SirLynix
Copy link
Member

@SirLynix SirLynix commented on e470863 Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Edit: Oh, I though it was windows default but it's xmake own xmake.lua, so I guess it's to make it independent from msvc dll

@waruqi
Copy link
Member Author

@waruqi waruqi commented on e470863 Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried switching to MD, but it didn't reduce the size of the installation package much, and it doesn't work on XP, it relies on a specific version of the msvc dll. This may cause some system compatibility issues with the xmake installation package.

Please sign in to comment.