Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsxmake project generator, very slow #5573

Open
maximegmd opened this issue Sep 5, 2024 · 15 comments
Open

vsxmake project generator, very slow #5573

maximegmd opened this issue Sep 5, 2024 · 15 comments
Labels
bug

Comments

@maximegmd
Copy link

Xmake Version

2.9.4

Operating System Version and Architecture

Windows 11

Describe Bug

When running xmake project -k vsxmake on a project with 50 000 source file, it runs for hours.

This does not happen with the old vs generator. Running xmake directly to build is also not affected.

Expected Behavior

It doesn't take hours.

Project Configuration

n/a

Additional Information and Error Logs

n/a
@maximegmd maximegmd added the bug label Sep 5, 2024
@waruqi
Copy link
Member

waruqi commented Sep 5, 2024

you can set -m mode and -a arch to reduce it.

@maximegmd
Copy link
Author

you can set -m mode and -a arch to reduce it.

Tried it, canceled the job after 30 minutes, it didn't help.

@waruqi
Copy link
Member

waruqi commented Sep 5, 2024

please provide verbose logs

@maximegmd
Copy link
Author

There are no logs, it just hangs for hours after the initial checks:

(base) PS F:\Dev\HogwartsMods\Hogwarp> xmake project -k vsxmake -vD
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for Microsoft Visual Studio (x64) version ... 2022
checking for Microsoft C/C++ Compiler (x64) version ... 19.41.34120
checkinfo: cannot runv(zig.exe version), No such file or directory
checking for zig ... no
checkinfo: cannot runv(zig.exe version), No such file or directory
checking for zig ... no
checkinfo: cannot runv(nim.exe --version), No such file or directory
checking for nim ... no
checkinfo: cannot runv(nim.exe --version), No such file or directory
checking for nim ... no
checking for unzip ... ok
checking for git ... ok
checking for gzip ... ok
checking for tar ... ok
git rev-parse HEAD
finding mem from xmake ..
checking for xmake::mem ... mem 1.0.0
finding imgui from xmake ..
checking for xmake::imgui ... imgui v1.91.0
finding xbyak from xmake ..
checking for xmake::xbyak ... xbyak v7.06
finding minhook from xmake ..
checking for xmake::minhook ... minhook v1.3.3
checking for aqt ... no
checking for Qt SDK directory ... C:/Users/Work/AppData/Local/.xmake/packages/q/qt6base/6.8.0/b40ce8b80f0449248b45b9fbf1bcfe6e
checking for Qt SDK version ... 6.8.0
checking for xmake-repo::qt6base ... qt6base 6.8.0
checking for xmake-repo::qt6core ... qt6core 6.8.0
checking for xmake-repo::qt6gui ... qt6gui 6.8.0
checking for xmake-repo::qt6widgets ... qt6widgets 6.8.0
finding hopscotch-map from xmake ..
checking for xmake::hopscotch-map ... hopscotch-map v2.3.1
checking for cmake ... no
checking for cmake ... no
checking for cmake ... no
checking for cmake ... C:\Program Files\CMake\bin\cmake
finding snappy from xmake ..
checking for xmake::snappy ... snappy 1.1.10
finding mimalloc from xmake ..
checking for xmake::mimalloc ... mimalloc 2.1.7
finding openssl from xmake ..
checking for xmake::openssl ... openssl 1.1.1-w
finding abseil from xmake ..
checking for xmake::abseil ... abseil 20240722.0
finding protobuf-cpp from xmake ..
checking for xmake::protobuf-cpp ... protobuf-cpp 28.0
finding gamenetworkingsockets from xmake ..
checking for xmake::gamenetworkingsockets ... gamenetworkingsockets v1.4.1
finding catch2 from xmake ..
checking for xmake::catch2 ... catch2 v2.13.9
finding libuv from xmake ..
checking for xmake::libuv ... libuv v1.48.0
finding spdlog from xmake ..
checking for xmake::spdlog ... spdlog v1.14.1
finding cryptopp from xmake ..
checking for xmake::cryptopp ... cryptopp 8.9.0
finding protobuf-cpp from xmake ..
checking for xmake::protobuf-cpp ... protobuf-cpp 3.19.4
finding glm from xmake ..
checking for xmake::glm ... glm 1.0.1
finding zlib from xmake ..
checking for xmake::zlib ... zlib v1.3.1
finding nlohmann_json from xmake ..
checking for xmake::nlohmann_json ... nlohmann_json v3.11.3
finding dotnet from xmake ..
checking for xmake::dotnet ... dotnet 8.0.6
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for the c++ compiler (cxx) ... cl.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the linker (ld) ... link.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the shared library linker (sh) ... link.exe
generating code\encoding\BuildInfo.h.in to build\BuildInfo.h ..
  > replace GIT_BRANCH -> dev
  > replace GIT_COMMIT -> ec9964cf
generating code\encoding\BuildInfo.h.in ... cache
configure
{
    ndk_stdcxx = true
    mode = release
    kind = static
    plat = windows
    host = windows
    qt = C:/Users/Work/AppData/Local/.xmake/packages/q/qt6base/6.8.0/b40ce8b80f0449248b45b9fbf1bcfe6e
    vs = 2022
    arch = x64
    buildir = build
    qt_sdkver = 6.8.0
    ccache = true
}
using project kind vs2022
checking for debug.x64 ...
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for Microsoft Visual Studio (x64) version ... 2022
checking for Microsoft C/C++ Compiler (x64) version ... 19.41.34120
checkinfo: cannot runv(zig.exe version), No such file or directory
checking for zig ... no
checkinfo: cannot runv(zig.exe version), No such file or directory
checking for zig ... no
checkinfo: cannot runv(nim.exe --version), No such file or directory
checking for nim ... no
checkinfo: cannot runv(nim.exe --version), No such file or directory
checking for nim ... no
checking for unzip ... ok
checking for git ... ok
checking for gzip ... ok
checking for tar ... ok
finding mem from xmake ..
checking for xmake::mem ... mem 1.0.0
finding imgui from xmake ..
checking for xmake::imgui ... imgui v1.91.0
finding xbyak from xmake ..
checking for xmake::xbyak ... xbyak v7.06
finding minhook from xmake ..
checking for xmake::minhook ... minhook v1.3.3
checking for aqt ... no
checking for Qt SDK directory ... C:/Users/Work/AppData/Local/.xmake/packages/q/qt6base/6.8.0/b40ce8b80f0449248b45b9fbf1bcfe6e
checking for Qt SDK version ... 6.8.0
checking for xmake-repo::qt6base ... qt6base 6.8.0
checking for xmake-repo::qt6core ... qt6core 6.8.0
checking for xmake-repo::qt6gui ... qt6gui 6.8.0
checking for xmake-repo::qt6widgets ... qt6widgets 6.8.0
finding hopscotch-map from xmake ..
checking for xmake::hopscotch-map ... hopscotch-map v2.3.1
checking for cmake ... no
checking for cmake ... no
checking for cmake ... no
checking for cmake ... C:\Program Files\CMake\bin\cmake
finding snappy from xmake ..
checking for xmake::snappy ... snappy 1.1.10
finding mimalloc from xmake ..
checking for xmake::mimalloc ... mimalloc 2.1.7
finding openssl from xmake ..
checking for xmake::openssl ... openssl 1.1.1-w
finding abseil from xmake ..
checking for xmake::abseil ... abseil 20240722.0
finding protobuf-cpp from xmake ..
checking for xmake::protobuf-cpp ... protobuf-cpp 28.0
finding gamenetworkingsockets from xmake ..
checking for xmake::gamenetworkingsockets ... gamenetworkingsockets v1.4.1
finding catch2 from xmake ..
checking for xmake::catch2 ... catch2 v2.13.9
finding libuv from xmake ..
checking for xmake::libuv ... libuv v1.48.0
finding spdlog from xmake ..
checking for xmake::spdlog ... spdlog v1.14.1
finding cryptopp from xmake ..
checking for xmake::cryptopp ... cryptopp 8.9.0
finding protobuf-cpp from xmake ..
checking for xmake::protobuf-cpp ... protobuf-cpp 3.19.4
finding glm from xmake ..
checking for xmake::glm ... glm 1.0.1
finding zlib from xmake ..
checking for xmake::zlib ... zlib v1.3.1
finding nlohmann_json from xmake ..
checking for xmake::nlohmann_json ... nlohmann_json v3.11.3
finding dotnet from xmake ..
checking for xmake::dotnet ... dotnet 8.0.6
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for the c++ compiler (cxx) ... cl.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the linker (ld) ... link.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the shared library linker (sh) ... link.exe
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for the c compiler (cc) ... cl.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the static library archiver (ar) ... link.exe
checking for release.x64 ...
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for Microsoft Visual Studio (x64) version ... 2022
checking for Microsoft C/C++ Compiler (x64) version ... 19.41.34120
checkinfo: cannot runv(zig.exe version), No such file or directory
checking for zig ... no
checkinfo: cannot runv(zig.exe version), No such file or directory
checking for zig ... no
checkinfo: cannot runv(nim.exe --version), No such file or directory
checking for nim ... no
checkinfo: cannot runv(nim.exe --version), No such file or directory
checking for nim ... no
checking for unzip ... ok
checking for git ... ok
checking for gzip ... ok
checking for tar ... ok
finding mem from xmake ..
checking for xmake::mem ... mem 1.0.0
finding imgui from xmake ..
checking for xmake::imgui ... imgui v1.91.0
finding xbyak from xmake ..
checking for xmake::xbyak ... xbyak v7.06
finding minhook from xmake ..
checking for xmake::minhook ... minhook v1.3.3
checking for aqt ... no
checking for Qt SDK directory ... C:/Users/Work/AppData/Local/.xmake/packages/q/qt6base/6.8.0/b40ce8b80f0449248b45b9fbf1bcfe6e
checking for Qt SDK version ... 6.8.0
checking for xmake-repo::qt6base ... qt6base 6.8.0
checking for xmake-repo::qt6core ... qt6core 6.8.0
checking for xmake-repo::qt6gui ... qt6gui 6.8.0
checking for xmake-repo::qt6widgets ... qt6widgets 6.8.0
finding hopscotch-map from xmake ..
checking for xmake::hopscotch-map ... hopscotch-map v2.3.1
checking for cmake ... no
checking for cmake ... no
checking for cmake ... no
checking for cmake ... C:\Program Files\CMake\bin\cmake
finding snappy from xmake ..
checking for xmake::snappy ... snappy 1.1.10
finding mimalloc from xmake ..
checking for xmake::mimalloc ... mimalloc 2.1.7
finding openssl from xmake ..
checking for xmake::openssl ... openssl 1.1.1-w
finding abseil from xmake ..
checking for xmake::abseil ... abseil 20240722.0
finding protobuf-cpp from xmake ..
checking for xmake::protobuf-cpp ... protobuf-cpp 28.0
finding gamenetworkingsockets from xmake ..
checking for xmake::gamenetworkingsockets ... gamenetworkingsockets v1.4.1
finding catch2 from xmake ..
checking for xmake::catch2 ... catch2 v2.13.9
finding libuv from xmake ..
checking for xmake::libuv ... libuv v1.48.0
finding spdlog from xmake ..
checking for xmake::spdlog ... spdlog v1.14.1
finding cryptopp from xmake ..
checking for xmake::cryptopp ... cryptopp 8.9.0
finding protobuf-cpp from xmake ..
checking for xmake::protobuf-cpp ... protobuf-cpp 3.19.4
finding glm from xmake ..
checking for xmake::glm ... glm 1.0.1
finding zlib from xmake ..
checking for xmake::zlib ... zlib v1.3.1
finding nlohmann_json from xmake ..
checking for xmake::nlohmann_json ... nlohmann_json v3.11.3
finding dotnet from xmake ..
checking for xmake::dotnet ... dotnet 8.0.6
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for the c++ compiler (cxx) ... cl.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the linker (ld) ... link.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the shared library linker (sh) ... link.exe
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for the c compiler (cc) ... cl.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the static library archiver (ar) ... link.exe
checking for releasedbg.x64 ...
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for Microsoft Visual Studio (x64) version ... 2022
checking for Microsoft C/C++ Compiler (x64) version ... 19.41.34120
checkinfo: cannot runv(zig.exe version), No such file or directory
checking for zig ... no
checkinfo: cannot runv(zig.exe version), No such file or directory
checking for zig ... no
checkinfo: cannot runv(nim.exe --version), No such file or directory
checking for nim ... no
checkinfo: cannot runv(nim.exe --version), No such file or directory
checking for nim ... no
checking for unzip ... ok
checking for git ... ok
checking for gzip ... ok
checking for tar ... ok
finding mem from xmake ..
checking for xmake::mem ... mem 1.0.0
finding imgui from xmake ..
checking for xmake::imgui ... imgui v1.91.0
finding xbyak from xmake ..
checking for xmake::xbyak ... xbyak v7.06
finding minhook from xmake ..
checking for xmake::minhook ... minhook v1.3.3
checking for aqt ... no
checking for Qt SDK directory ... C:/Users/Work/AppData/Local/.xmake/packages/q/qt6base/6.8.0/b40ce8b80f0449248b45b9fbf1bcfe6e
checking for Qt SDK version ... 6.8.0
checking for xmake-repo::qt6base ... qt6base 6.8.0
checking for xmake-repo::qt6core ... qt6core 6.8.0
checking for xmake-repo::qt6gui ... qt6gui 6.8.0
checking for xmake-repo::qt6widgets ... qt6widgets 6.8.0
finding hopscotch-map from xmake ..
checking for xmake::hopscotch-map ... hopscotch-map v2.3.1
checking for cmake ... no
checking for cmake ... no
checking for cmake ... no
checking for cmake ... C:\Program Files\CMake\bin\cmake
finding snappy from xmake ..
checking for xmake::snappy ... snappy 1.1.10
finding mimalloc from xmake ..
checking for xmake::mimalloc ... mimalloc 2.1.7
finding openssl from xmake ..
checking for xmake::openssl ... openssl 1.1.1-w
finding abseil from xmake ..
checking for xmake::abseil ... abseil 20240722.0
finding protobuf-cpp from xmake ..
checking for xmake::protobuf-cpp ... protobuf-cpp 28.0
finding gamenetworkingsockets from xmake ..
checking for xmake::gamenetworkingsockets ... gamenetworkingsockets v1.4.1
finding catch2 from xmake ..
checking for xmake::catch2 ... catch2 v2.13.9
finding libuv from xmake ..
checking for xmake::libuv ... libuv v1.48.0
finding spdlog from xmake ..
checking for xmake::spdlog ... spdlog v1.14.1
finding cryptopp from xmake ..
checking for xmake::cryptopp ... cryptopp 8.9.0
finding protobuf-cpp from xmake ..
checking for xmake::protobuf-cpp ... protobuf-cpp 3.19.4
finding glm from xmake ..
checking for xmake::glm ... glm 1.0.1
finding zlib from xmake ..
checking for xmake::zlib ... zlib v1.3.1
finding nlohmann_json from xmake ..
checking for xmake::nlohmann_json ... nlohmann_json v3.11.3
finding dotnet from xmake ..
checking for xmake::dotnet ... dotnet 8.0.6
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for the c++ compiler (cxx) ... cl.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the linker (ld) ... link.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the shared library linker (sh) ... link.exe
checking for cl.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\cl.exe
checking for the c compiler (cc) ... cl.exe
checking for link.exe ... C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.41.34120\bin\HostX64\x64\link.exe
checking for the static library archiver (ar) ... link.exe

@waruqi
Copy link
Member

waruqi commented Sep 6, 2024

you can try this way to get backtrace. #2033

@maximegmd
Copy link
Author

Did a few runs and here are the traces

[xmake]: [engine]: stack traceback:
        [C]: in function 'type'
        @programdir\core\base\table.lua:98: in function 'table.join'
        @programdir\plugins\project\vsxmake\render.lua:76: in global '_expand'
        @programdir\plugins\project\vsxmake\render.lua:89: in function <@programdir\plugins\project\vsxmake\render.lua:87>
        (...tail calls...)
        [C]: in function 'string.gsub'
        @programdir\plugins\project\vsxmake\render.lua:93: in function <@programdir\plugins\project\vsxmake\render.lua:87>
        (...tail calls...)
        @programdir\plugins\project\vsxmake\vsxmake.lua:247: in field '?'
        @programdir\plugins\project\main.lua:75: in global '_make'
        @programdir\plugins\project\main.lua:95: in function <@programdir\plugins\project\main.lua:78>
        (...tail calls...)
        [C]: in function 'xpcall'
        @programdir\core\base\utils.lua:275: in function 'sandbox/modules/utils.trycall'
        (...tail calls...)
        @programdir\core\base\task.lua:491: in function 'base/task.run'
        @programdir\core\main.lua:327: in upvalue 'cotask'
        @programdir\core\base\scheduler.lua:406: in function <@programdir\core\base\scheduler.lua:399>

[xmake]: [engine]: stack traceback:
        @programdir\core\base\table.lua:98: in function 'sandbox/modules/table.join'
        @programdir\core\base\table.lua:97: in function 'sandbox/modules/table.join'
        @programdir\plugins\project\vsxmake\render.lua:76: in global '_expand'
        @programdir\plugins\project\vsxmake\render.lua:89: in function <@programdir\plugins\project\vsxmake\render.lua:87>
        (...tail calls...)
        [C]: in function 'string.gsub'
        @programdir\plugins\project\vsxmake\render.lua:93: in function <@programdir\plugins\project\vsxmake\render.lua:87>
        (...tail calls...)
        @programdir\plugins\project\main.lua:75: in global '_make'
        @programdir\plugins\project\main.lua:95: in function <@programdir\plugins\project\main.lua:78>
        (...tail calls...)
        @programdir\plugins\project\main.lua:95: in function <@programdir\plugins\project\main.lua:78>
        (...tail calls...)
        [C]: in function 'xpcall'
        @programdir\core\base\utils.lua:275: in function 'sandbox/modules/utils.trycall'
        (...tail calls...)
        @programdir\core\base\task.lua:491: in function 'base/task.run'
        @programdir\core\base\scheduler.lua:406: in function <@programdir\core\base\scheduler.lua:399>
        @programdir\core\base\scheduler.lua:406: in function <@programdir\core\base\scheduler.lua:399>

[xmake]: [engine]: stack traceback:
        [C]: in function 'type'
        @programdir\core\base\table.lua:98: in function 'base/table.join'
        @programdir\plugins\project\vsxmake\render.lua:76: in global '_expand'
        [C]: in function 'base/string.gsub'
        [C]: in function 'base/string.gsub'
        @programdir\plugins\project\vsxmake\render.lua:93: in function <@programdir\plugins\project\vsxmake\render.lua:87>
        (...tail calls...)
        @programdir\plugins\project\vsxmake\vsxmake.lua:247: in field '?'
        @programdir\plugins\project\main.lua:95: in function <@programdir\plugins\project\main.lua:78>
        (...tail calls...)
        @programdir\plugins\project\main.lua:95: in function <@programdir\plugins\project\main.lua:78>
        (...tail calls...)
        [C]: in function 'xpcall'
        @programdir\core\base\utils.lua:275: in function 'base/utils.trycall'
        (...tail calls...)
        @programdir\core\base\task.lua:491: in function 'base/task.run'
        @programdir\core\base\scheduler.lua:406: in function <@programdir\core\base\scheduler.lua:399>
        @programdir\core\base\scheduler.lua:406: in function <@programdir\core\base\scheduler.lua:399>

waruqi added a commit that referenced this issue Sep 9, 2024
@waruqi
optimize vsxmake render #5573
ff963e1
@waruqi waruqi mentioned this issue Sep 9, 2024
Merged
@waruqi
Copy link
Member

waruqi commented Sep 9, 2024

Maybe we should optimize here, big projects can cause it to be very slow.

I know this place can continue to be optimized, but at the moment I can't optimize it very well.

This patch (#5588) I made some attempts to optimize, you can try it as well and see if it improves.

You can also try to debug it or help optimize it.

xmake/xmake/plugins/project/vsxmake/render.lua

Lines 62 to 96 in 7ae40eb

function _expand(params)
local r = {""}
for _, v in ipairs(params) do
if type(v) == "string" then
for i, p in ipairs(r) do
r[i] = p .. "\0" .. v
end
else
local newr = {}
for _, c in ipairs(v) do
local rcopy = {}
for i, p in ipairs(r) do
rcopy[i] = p .. "\0" .. c
end
newr = table.join(newr, rcopy)
end
r = newr
end
end
for i, p in ipairs(r) do
r[i] = p:split("\0")
end
return r
end
function _render(templatepath, opt, args)
local template = io.readfile(templatepath)
local params = _expand(opt.paramsprovider(args))
local replaced = ""
for _, v in ipairs(params) do
local tmpl = template:gsub(opt.cpattern, _cfill(opt, v))
replaced = replaced .. tmpl:gsub(opt.pattern, _fill(opt, v))
end
return replaced
end

@OpportunityLiu @SirLynix Any idea?

@waruqi waruqi added this to the v2.9.5 milestone Sep 9, 2024
waruqi added a commit that referenced this issue Sep 9, 2024
@waruqi
optimize vsxmake render #5573
29ba59d
@SirLynix
Copy link
Member

SirLynix commented Sep 9, 2024

I think we should remake the vsxmake generator by forking vs generator and putting idea I had in another issue (use nmake settings to trigger xmake, like Unreal Engine does)

waruqi added a commit that referenced this issue Sep 9, 2024
@waruqi
Merge pull request #5588 from xmake-io/vsxmake
1dfec90 
optimize vsxmake render #5573
@waruqi
Copy link
Member

waruqi commented Sep 9, 2024

I think we should remake the vsxmake generator by forking vs generator and putting idea I had in another issue (use nmake settings to trigger xmake, like Unreal Engine does)

You can try it, but for now I can only try to optimize it first.

@maximegmd Will the new patch be faster?

@maximegmd
Copy link
Author

@waruqi I am unable to run as I am hitting this xmake-io/xmake-repo#5180 after a clean install

@waruqi
Copy link
Member

waruqi commented Sep 10, 2024

@waruqi I am unable to run as I am hitting this xmake-io/xmake-repo#5180 after a clean install

try it again.

xmake-io/xmake-repo#5180 (comment)

@maximegmd
Copy link
Author

This helps a lot; it now takes 10 minutes vs a few hours before.

That being said, I think we should keep this issue open to track vsxmake improvements, even 10 minutes is quite slow.

@SirLynix
Copy link
Member

how long does vs generator take?

@maximegmd
Copy link
Author

Less than a minute

@waruqi
Copy link
Member

waruqi commented Sep 11, 2024 •
edited
Loading

Can you provide a new stuck backtrace?

@waruqi waruqi modified the milestones: v2.9.5, v2.9.6 Sep 11, 2024
@waruqi waruqi removed this from the v2.9.6 milestone Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@waruqi @maximegmd @SirLynix