-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xpack: wix toolset support #4788
Conversation
Does it ready now? |
There are a few things missing (unit tests, ...), I will test again tomorrow and the review can be done this weekend. |
you can add this new format in test. xmake/tests/plugins/pack/xmake.lua Line 22 in c31fa8f
it will be tested on ci. |
Then file icon is not working
Thanks, I will test it in these days. |
I tried it, but I get some errors. > xmake pack -f wix
packing build\xpack\test\test-windows-x64-v1.0.0.msi
note: install or modify (m) these packages (pass -y to skip confirm)?
in xmake-repo:
-> wixtoolset 5.0.0
please input: y (y/n/m)
=> install wixtoolset 5.0.0 .. ok
error: wix.exe : error WIX0144: The extension 'WixToolset.UI.wixext' could not be found. Checked paths: WixToolset.UI.wixext
|
I think I know why.
|
package:addenv("WIX_EXTENSIONS", package:installdir("bin")) We should set relative path. package:addenv("WIX_EXTENSIONS", "bin") |
I fixed it, at least the first run, it works. But the second run still has this problem. But when running wix for the second time it still has the problem. |
And you can add |
You can continue to improve it to And I will aslo improve it. |
I have fixed it. |
TODO:
There are two drawbacks:
before_installcmd
orafter_installcmd
can be executed at the same time.