-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement os.SIGDFL and os.SIGIGN #4895
Conversation
or we can use os.signal(os.SIGINT, {reset = true})
os.signal(os.SIGINT, {ignore = true}) |
If you can help to add some tests, it will be better. |
you can add doc in https://github.com/xmake-io/xmake-docs/blob/master/manual/builtin_modules.md#os |
I don't quite like using dictionary just for named value, it's easy to make a typo and not get any feedback. I think cleaner would be to create one function for each:
Notes:
|
I wouldn't consider adding too much API to the os module for signal. please only use Or use a separate signal module. signal.register(signo, handler)
signal.ignore(signo)
signal.reset(signo) |
Understood, how about putting it in |
no, process is only used to run and manage a single child process. |
see #4908 |
Fixes: #4889
Allows user to reset the previously overwritten
os.signal
or ignore it completely (not passed to process, same as with{ exclusive = true }
.Opens:
signal_default/reset
andsignal_ignore
instead of Unix'sSIGDFL
andSIGIGN
?