-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for --runtimes for autoconf, cmake, make and meson packages #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthapz
changed the title
add support for --runtimes on autoconf, cmake, make and meson buildsystems
add support for --runtimes for autoconf, cmake, make and meson packages
Apr 3, 2024
waruqi
reviewed
Apr 9, 2024
waruqi
reviewed
Apr 9, 2024
@@ -304,6 +304,16 @@ function buildenvs(package, opt) | |||
table.join2(cxxflags, package:_generate_lto_configs("cxx").cxxflags) | |||
table.join2(ldflags, package:_generate_lto_configs().ldflags) | |||
end | |||
local runtimes = package:config("runtimes") | |||
if runtimes then | |||
local fake_target = {is_shared = function(_) return false end, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not pass package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here. why?
waruqi
reviewed
Apr 9, 2024
waruqi
reviewed
Apr 9, 2024
waruqi
reviewed
Apr 9, 2024
Arthapz
force-pushed
the
improve-package-runtimes
branch
from
April 10, 2024 14:03
0bba1c2
to
546dd2e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft because depends of #4921