Pass --sdk to dependencies #5918
Conversation
|
We don't always pass the sdk, it's only required for cross-compilation and toolchains like mingw. what's your toolchain and platform? xmake/xmake/modules/package/tools/xmake.lua Line 202 in 71a5624 xmake/xmake/modules/package/tools/xmake.lua Line 176 in 71a5624 |
I'm using msvc-wine and host is Arch Linux. |
|
you should add it in _get_configs_for_windows() function _get_configs_for_windows()
if not is_host("windows") then
-- pass sdk
end
end |
This makes sense, I've applied the changes. |
| @@ -89,6 +89,13 @@ function _get_configs_for_windows(package, configs, opt) | |||
| if package:config("toolchains") and _is_toolchain_compatible_with_host(package) then | |||
| _get_configs_for_host_toolchain(package, configs, opt) | |||
| end | |||
|
|
|||
| if not is_host("windows") then | |||
| local sdk = get_config("sdk") | |||
There was a problem hiding this comment.
local sdkdir = _get_config_from_toolchains(package, "sdkdir") or get_config("sdk")
There was a problem hiding this comment.
My bad, your original message was too ambiguous for me to pick up on the requested change.
This fixes #5917.
This is my first pull request for this project, please let me know if there's anything missing or if I did something wrong.