Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seg fault when -c used with --pass/--userpass/--user #271

Closed
aleqx opened this issue Oct 23, 2018 · 6 comments
Closed

seg fault when -c used with --pass/--userpass/--user #271

aleqx opened this issue Oct 23, 2018 · 6 comments
Assignees
Labels
Milestone

Comments

@aleqx
Copy link

aleqx commented Oct 23, 2018

Compiled latest master on Ubuntu 16.04. If I try:

./xmrig-proxy -c cn-heavy.json --pass=foobar:x

It exits with a segmentation fault.

The above would be useful so that I can use the same .json file but only change the password for various pools (usually the worker name).

@xmrig
Copy link
Owner

xmrig commented Nov 4, 2018

Fixed, but it works as you expected only if cn-heavy.json contains only one pool, otherwise only last pool in list will be changed and hard to change this behavior without add additional options.
Thank you.

@aleqx
Copy link
Author

aleqx commented Nov 4, 2018

Thank you. It's a shame it only affects the last defined pool - is it that difficult to change it for all defined pools?

@xmrig
Copy link
Owner

xmrig commented Nov 4, 2018

It's not so hard to implement, but required to add new option with new name, maybe --pass-override etc.

@aleqx
Copy link
Author

aleqx commented Nov 4, 2018

I was saying that if I use xmrig-proxy -c cn.json --pass foo (specifically, I use --pass foo after -c cn.json) then that should override all passwords in the pools ... I don't see why there should be a new option.

Generally, my suggestion was that any command line option used after (or before) -c cn.json should override the value of the same option inside cn.json. For example, xmrig-proxy -c cn.json --verbosity 0 would set verbosity to 1, overriding whatever is in cn.json.

@xmrig
Copy link
Owner

xmrig commented Nov 4, 2018

Internally config parser don't know it JSON value or command line or second config.

@xmrig xmrig self-assigned this Nov 4, 2018
@xmrig xmrig added this to the v2.9.0 milestone Nov 4, 2018
@xmrig
Copy link
Owner

xmrig commented Jan 17, 2019

Fixed in v2.9.1 release.
Thank you.

@xmrig xmrig closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants