Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit code in ESM format #34

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Emit code in ESM format #34

merged 1 commit into from
Aug 17, 2019

Conversation

vkrol
Copy link
Contributor

@vkrol vkrol commented Aug 17, 2019

Right now, the library is not tree shakeable. These changes will enable tree shaking.

@@ -1,6 +1,7 @@
{
"compilerOptions": {
"module": "commonjs",
"moduleResolution": "node",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed for compiling to ESM.

@xnimorz
Copy link
Owner

xnimorz commented Aug 17, 2019

Great work!
Thank you, @vkrol !
I'll publish it with your previous PR #33

@vkrol
Copy link
Contributor Author

vkrol commented Aug 17, 2019

You are welcome. I can rebase this branch when #33 will be merged.

@xnimorz xnimorz merged commit 171101d into xnimorz:master Aug 17, 2019
@xnimorz
Copy link
Owner

xnimorz commented Aug 17, 2019

I've published [email protected] with these changes.

Thank you for contributing!

@vkrol vkrol deleted the emit-esm branch August 18, 2019 07:26
@vkrol
Copy link
Contributor Author

vkrol commented Aug 18, 2019

Awesome. No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants