g10k not stopping on wrong :commit

[chutzimir]

Steps to reproduce:

$ cat > Puppetfile <<EOF
mod 'stdlib',
  :git    => 'https://github.com/puppetlabs/puppetlabs-stdlib.git',
  :commit => '0000000000000000000000000000000000000000'
EOF

$ g10k -puppetfile -debug
2018/02/08 20:01:55 DEBUG main(): Trying to use as Puppetfile: ./Puppetfile
2018/02/08 20:01:55 DEBUG checkDirAndCreate(): Using as cachedir default value: /tmp/g10k/
2018/02/08 20:01:55 DEBUG readPuppetfile(): Trying to parse: ./Puppetfile
2018/02/08 20:01:55 DEBUG preparePuppetfile(): adding line:mod 'stdlib',
2018/02/08 20:01:55 DEBUG preparePuppetfile(): adding line::git    => 'https://github.com/puppetlabs/puppetlabs-stdlib.git',
2018/02/08 20:01:55 DEBUG preparePuppetfile(): adding line::commit => '0000000000000000000000000000000000000000'
2018/02/08 20:01:55 DEBUG readPuppetfile(): Setting moduledir for Puppetfile ./Puppetfile to modules
2018/02/08 20:01:55 DEBUG resolvePuppetfile(): Resolving cmdlineparam
2018/02/08 20:01:55 DEBUG resolveForgeModules(): empty ForgeModule[] found, skipping...
2018/02/08 20:01:55 DEBUG timeTrack(): resolveForgeModules() took 0.00001s
2018/02/08 20:01:55 DEBUG resolveGitRepositories(): Resolving 1 Git modules with 50 workers
2018/02/08 20:01:55 DEBUG resolveGitRepositories(): git repo url https://github.com/puppetlabs/puppetlabs-stdlib.git
2018/02/08 20:01:55 DEBUG git repo url https://github.com/puppetlabs/puppetlabs-stdlib.git without ssh key
2018/02/08 20:01:55 DEBUG executeCommand(): Executing git clone --mirror https://github.com/puppetlabs/puppetlabs-stdlib.git /tmp/g10k/https-__github.com_puppetlabs_puppetlabs-stdlib.git
2018/02/08 20:01:58 Executing git clone --mirror https://github.com/puppetlabs/puppetlabs-stdlib.git /tmp/g10k/https-__github.com_puppetlabs_puppetlabs-stdlib.git took 3.47622s
2018/02/08 20:01:58 DEBUG timeTrack(): resolveGitRepositories() took 3.47632s
2018/02/08 20:01:58 DEBUG resolvePuppetfile(): Syncing cmdlineparam with workDir .
2018/02/08 20:01:58 DEBUG checkDirAndCreate(): Using as basedir 2 for source cmdlineparam: ./
2018/02/08 20:01:58 DEBUG checkDirAndCreate(): Using as moduleDir for cmdlineparam: ./modules/
2018/02/08 20:01:58 DEBUG executeCommand(): Executing git --git-dir /tmp/g10k/https-__github.com_puppetlabs_puppetlabs-stdlib.git rev-parse --verify '0000000000000000000000000000000000000000'
2018/02/08 20:01:58 Executing git --git-dir /tmp/g10k/https-__github.com_puppetlabs_puppetlabs-stdlib.git rev-parse --verify '0000000000000000000000000000000000000000' took 0.00189s
Need to sync ./modules/stdlib/
2018/02/08 20:01:58 DEBUG createOrPurgeDir(): Trying to create dir: ./modules/stdlib/ called from syncToModuleDir()
2018/02/08 20:01:58 DEBUG syncToModuleDir(): Executing git --git-dir /tmp/g10k/https-__github.com_puppetlabs_puppetlabs-stdlib.git archive 0000000000000000000000000000000000000000
2018/02/08 20:01:58 syncToModuleDir(): Executing git --git-dir /tmp/g10k/https-__github.com_puppetlabs_puppetlabs-stdlib.git archive 0000000000000000000000000000000000000000 took 0.00158s
2018/02/08 20:01:58 DEBUG executeCommand(): Executing git --git-dir /tmp/g10k/https-__github.com_puppetlabs_puppetlabs-stdlib.git rev-parse --verify '0000000000000000000000000000000000000000'
2018/02/08 20:01:58 Executing git --git-dir /tmp/g10k/https-__github.com_puppetlabs_puppetlabs-stdlib.git rev-parse --verify '0000000000000000000000000000000000000000' took 0.00177s
2018/02/08 20:01:58 DEBUG syncToModuleDir(): Writing hash 0000000000000000000000000000000000000000
 from command git --git-dir /tmp/g10k/https-__github.com_puppetlabs_puppetlabs-stdlib.git rev-parse --verify '0000000000000000000000000000000000000000' to ./modules/stdlib//.latest_commit
2018/02/08 20:01:58 DEBUG main(): Forge response JSON parsing took 0.0000 seconds
2018/02/08 20:01:58 DEBUG main(): Forge modules metadata.json parsing took 0.0000 seconds
Synced ./Puppetfile with 1 git repositories and 0 Forge modules in 3.5s with git (3.5s sync, I/O 0.0s) and Forge (0.0s query+download, I/O 0.0s) using 50 resolv and 20 extract workers

$ echo $?
0

$ find
.
./modules
./modules/stdlib
./modules/stdlib/.latest_commit
./Puppetfile

$ cat modules/stdlib/.latest_commit
0000000000000000000000000000000000000000

I was expecting the g10k command to fail.

[xorpaul]

Yeah, and g10k is expecting git rev-parse --verify to fail. 😏

[xorpaul]

Hmm, I could also adjust the parameter to check for really existing objects and not accept commit-ish looking parameters. Taken from the git-rev-parse(1) man page:

$ git --git-dir tmp/modules/https-__github.com_puppetlabs_puppetlabs-apache.git rev-parse --verify "e587f2af793111adab04bb776808f99a09ca092b^{object}"   
e587f2af793111adab04bb776808f99a09ca092b
$ git --git-dir tmp/modules/https-__github.com_puppetlabs_puppetlabs-apache.git rev-parse --verify "0000000000000000000000000000000000000000^{object}"   
fatal: Needed a single revision                      
$ git --git-dir tmp/modules/https-__github.com_puppetlabs_puppetlabs-apache.git rev-parse --verify "master^{object}"                                     
e587f2af793111adab04bb776808f99a09ca092b             
$ git --git-dir tmp/modules/https-__github.com_puppetlabs_puppetlabs-apache.git rev-parse --verify "641576a137a6d1b401510308dda462f076c1559d^{object}"   
641576a137a6d1b401510308dda462f076c1559d             
$ git --git-dir tmp/modules/https-__github.com_puppetlabs_puppetlabs-apache.git rev-parse --verify "release^{object}"                                    
3e399f6e74acf0f80c7ad84217faea281e7a272e 

[xorpaul]

Also fixed with 9d8ab0e#diff-b112433c20987b983fa33aa1eac9482dR136