Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTT / KeepAlive : incorrect update settings #515

Closed
bopnrgi opened this issue Feb 3, 2018 · 2 comments
Closed

MQTT / KeepAlive : incorrect update settings #515

bopnrgi opened this issue Feb 3, 2018 · 2 comments
Assignees
@xoseperez
Labels
bug mqtt
Milestone
1.12.4

Comments

@bopnrgi
Copy link

bopnrgi commented Feb 3, 2018

MQTT KeepAlive seems don't be updated correctly. I set 310 seconds. After reboot is 54 seconds.

To reproduce. Enable MQTT, set KeepAlive to 310, save, reboot device. MQTT page display now 53.
Firmware Sonoff TH 1.12.3

Bonus : Is it possible to debug MQTT KeepAlive (via telnet ?) ?
@xoseperez xoseperez added this to the 1.12.4 milestone Feb 3, 2018
@xoseperez xoseperez self-assigned this Feb 3, 2018
@xoseperez
Copy link
Owner

Indeed, the internal variable that caches the keepalive time was defined as unsigned char, so a max of 255 seconds... I have fixed it and pushed to dev.

xoseperez added a commit that referenced this issue Feb 3, 2018
@xoseperez
Fix MQTT keep alive cannot be more than 255 seconds (#515)
6ef4d13
@xoseperez xoseperez mentioned this issue Feb 18, 2018
Closed
@xoseperez
Copy link
Owner

This is staged for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xoseperez xoseperez

Labels
bug mqtt
Projects
None yet
Milestone
1.12.4
Development

No branches or pull requests
2 participants
@xoseperez @bopnrgi