Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for week of Jan 20 #239

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Changes for week of Jan 20 #239

merged 1 commit into from
Jan 23, 2025

Conversation

duglin
Copy link
Contributor

@duglin duglin commented Jan 18, 2025

  • Misc typos/clean-up
  • Require target to NOT point to a model entity that uses ximport.
    Meaning, target is not transitive - to keep things simple.
  • Tweak usage of target. Can be on any relative URL/URI, and if value starts
    with / then it must match the xid template. Similar for relation but
    relation must be an xid... but target is optional for all types.
  • Add "deprecated" to messages and schemas
  • define "xref" as a "relation" type with "target"="self-xid"
  • add "modelversion" as a model label
  • make ?compact convert self, COLLECTONSurl, defaultverionurl into relative
    URLs if they're part of the response
  • mandate that all relative URLs start with "/" and they're relative to the
    root path of the Registry
  • ban model changes that turn on hasDoc if Resources have RESOURCE* attribute
    extension names

Fixes: #236
Fixes: #226
Fixes: #227
Fixes: #189
Fixes: #238

@duglin duglin force-pushed the Jan20 branch 3 times, most recently from f6d2552 to 1fb31bf Compare January 21, 2025 19:16
@duglin duglin force-pushed the Jan20 branch 6 times, most recently from 53859a2 to 1ee1675 Compare January 23, 2025 16:12
- Misc typos/clean-up
- Require `target` to NOT point to a model entity that uses `ximport`.
  Meaning, `target` is not transitive - to keep things simple.
- Tweak usage of `target`. Can be on any relative URL/URI, and if value starts
  with `/` then it must match the xid template. Similar for `relation` but
  `relation` must be an xid... but `target` is optional for all types.
- Add "deprecated" to messages and schemas
- define "xref" as a "relation" type with "target"="self-xid"
- add "modelversion" as a model label
- make ?compact convert self, COLLECTONSurl, defaultverionurl into relative
  URLs if they're part of the response
- mandate that all relative URLs start with "/" and they're relative to the
  root path of the Registry
- ban model changes that turn on hasDoc if Resources have RESOURCE* attribute
  extension names

Fixes: xregistry#236
Fixes: xregistry#226
Fixes: xregistry#227
Fixes: xregistry#189

Signed-off-by: Doug Davis <[email protected]>
@duglin
Copy link
Contributor Author

duglin commented Jan 23, 2025

Approved on the 1/23 call

@duglin duglin merged commit 5514807 into xregistry:main Jan 23, 2025
2 checks passed
@duglin duglin deleted the Jan20 branch January 24, 2025 00:13
duglin added a commit to duglin/xreg-spec that referenced this pull request Feb 11, 2025
Changes for week of Jan 20

Signed-off-by: Doug Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant