-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: adopt semantic versioning rules and postpone 1.0.0 release #197
Comments
v1 doesn't necessarily mean everything is amazing. If anything a v1 release would enable semantic versioning to do what it does which would be helpful for consumers as the API will not get any breaking changes until there is another major version bump. Before v1, API breakages are disregarded as the API is seen as unstable, meaning consumers need to lock against the patch version, not the minor version. Also as far as I can tell, there haven't really been any breaking changes recently, only fixes and additions. That being said, it may make sense to backtrack until discussions that I just started today, #195 and #196 are resolved. I do not think the lack of tests is a reason not to do a v1 release though, tests and documentation can be continuously improved in minor/patch releases. |
I guess I just got the bad cop role and I dont like it but - I see the following changes ahead that might break the API since they are somewhat fundamental:
For me xterm.js is not ready for 1.0.0 yet (from a QA point of view), maybe we have different views on what a v1 release should deliver. Well it is just a proposal ;) All of this is also addressable with any next major release, of course. |
I wouldn't necessarily think those 3 things would break the API though? The main |
...ah yes from an outer perspective xterm.js is IMO mature enough to hide those changes behind some abstraction layer. Well - not sure about the output rendering on this though... |
Thanks for your proposal @jerch. While there is much space for improvement in xterm.js, this does not mean that we should backtrack on the 1.0 release (which has already been released btw). I will stick mostly on the goal that you set on this issue:
Do you believe that a "Project status" section in the readme explaining the current status of the project, how versioning works, release cycles etc. could help? This could be also combined with #198. |
Oops didnt notice... Yes I think some clarification in the README is quite useful. |
Semantic versioning is a great way for peeps to get an idea of the state of some piece of software. Since xterm.js will have some impact in the node and browser world Im suggesting to adopt rules from semantic versioning to give the audience a chance to catch the actual state of xterm.js and its development.
To phrase it differently - is xterm.js ready for a 1.0.0. release yet?
I have to admit that I would expect at least the following for a so called stable release:
If you like the idea of adopting semantic versioning I propose to leave the 1.0.0 version idea and change it to an interim beta release with some minor version number. This would lower the burden to maintain a stable release with already known flaws and give time to focus on the problems at hand like refactoring and test coverage.
The text was updated successfully, but these errors were encountered: