Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial webpack implementation #196

Closed
wants to merge 3 commits into from
Closed

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 19, 2016

Part of #158


@parisk this PR is a bit messy at the moment, let me know your thoughts on the general approach here. Basically the following changes would come with/after this change:

  • Builds are done using webpack, the module is built at npm install time and the file that is relied upon is ./dist/xterm.js (see main in package.json)
  • Addons will be pulled out into their own repositories and published as independent modules, this means that not all addons need to be loaded at once and are more modular in nature
  • We can split out all the different pieces of logic in xterm.js into a well structured tree
  • Development is done by running:
    • First terminal: npm run dev to watch/compile sources
    • Second terminal: npm start to start server as before
  • Eventually change to exposing the library in an xtermjs object that contains a Terminal object would be preferable particularly for TypeScript as a proper typings file could be written for the library (ie. export { Terminal: Terminal }; vs export Terminal)
  • We can start using babel or similar to enable more elegant/efficient syntax without hurting compatibility in the resulting distributable
  • We can get rid of the AMD header as it's all handled by webpack
  • Allow minification/removal of comments in prod version, pushing the size of the distributable down significantly

@Tyriar
Copy link
Member Author

Tyriar commented Jul 22, 2016

@parisk any thoughts on the approach? Didn't want to continue until choice of tech, method, etc. was cool.

@parisk
Copy link
Contributor

parisk commented Aug 3, 2016

Sorry for being late here @Tyriar.

I have no significant webpack knowledge at the moment and TBH I am really reluctant to move forward with such a move without laying down first the pros and cons and examining alternatives.

I think that #158 is the best place to make some discussion about our options and choose the one that fits the project's needs better 😊 .

@Tyriar
Copy link
Member Author

Tyriar commented Aug 23, 2016

Closing as it's stale and going to try a TypeScript implementation.

@Tyriar Tyriar deleted the 158_add_webpack branch February 3, 2017 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants