Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt @playwright/test and use JSHandle #3446

Closed
Tyriar opened this issue Aug 31, 2021 · 3 comments
Closed

Adopt @playwright/test and use JSHandle #3446

Tyriar opened this issue Aug 31, 2021 · 3 comments
Assignees
Labels
type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 31, 2021

I'm using the new @playwright/test package in Luna Paint and it's essentially just doing what we're doing but in a much nicer way so we should adopt it. Additionally we should move away from just evaluating strings in page.evaluate to fetching a JSHandle to the xterm API and using that to test which would give us strong typing on the renderer side.

@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Aug 31, 2021
@Tyriar Tyriar self-assigned this Aug 31, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Aug 31, 2021

@Tyriar
Copy link
Member Author

Tyriar commented Dec 13, 2023

This is done for the most part

@Tyriar Tyriar closed this as completed Dec 13, 2023
@mxschmitt
Copy link

Great work @Tyriar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants