Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze when ligature addon #3593

Closed
SquitchYT opened this issue Dec 28, 2021 · 5 comments · Fixed by #3598
Closed

Freeze when ligature addon #3593

SquitchYT opened this issue Dec 28, 2021 · 5 comments · Fixed by #3598
Labels
area/addon/ligatures type/bug Something is misbehaving type/upstream The issue's cause is related to an upstream dependency
Milestone
4.17.0

Comments

@SquitchYT
Copy link
Contributor

Details

  • Browser and browser version: electron v11.5
  • OS version: ArchLinux
  • xterm.js version: 4.16

Steps to reproduce

  1. Add ligature addon
  2. Set the font to something that accept ligation (Fira Code for example)
  3. The app freeze indefinitely without error
@SquitchYT
Copy link
Contributor Author

This issue is probably related to princjef/font-ligatures#23.
However, it is impossible to dispose the addon. Nothing happen when I use .dispose() and the ligature remains activated

@Tyriar
Copy link
Member

Tyriar commented Jan 4, 2022

Maybe related to crash in microsoft/vscode#139537 (comment)

@Tyriar Tyriar added area/addon/ligatures type/bug Something is misbehaving type/upstream The issue's cause is related to an upstream dependency labels Jan 4, 2022
@Eugeny
Copy link
Member

Eugeny commented Jan 4, 2022

@Tyriar I second @SquitchYT, the hang is inside font-ligatures and it happens for specific font files only.

@LabhanshAgrawal
Copy link
Contributor

I'd opened princjef/font-ligatures#24 for this, yet to be merged though

@Tyriar
Copy link
Member

Tyriar commented Jan 6, 2022

Merged, figuring out how to release now 🙂

@LabhanshAgrawal LabhanshAgrawal mentioned this issue Jan 7, 2022
Merged
@Tyriar Tyriar added this to the 4.17.0 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/addon/ligatures type/bug Something is misbehaving type/upstream The issue's cause is related to an upstream dependency
Projects
None yet
Milestone
4.17.0
Development

Successfully merging a pull request may close this issue.

Bump font-ligatures to 1.4.1 LabhanshAgrawal/xterm.js
4 participants
@Eugeny @Tyriar @LabhanshAgrawal @SquitchYT