Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utf8ToUtf32 decoder full codepoint test can timeout in CI #4178

Closed
Tyriar opened this issue Oct 6, 2022 · 3 comments · Fixed by #4179
Closed

Utf8ToUtf32 decoder full codepoint test can timeout in CI #4178

Tyriar opened this issue Oct 6, 2022 · 3 comments · Fixed by #4179
Assignees
Labels
type/debt Technical debt that could slow us down in the long run
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 6, 2022

https://dev.azure.com/xtermjs/xterm.js/_build/results?buildId=5879&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=5852bf5a-5a02-52f3-bee8-4fdc90cda9d0

  1) text encodings
       Utf8ToUtf32 decoder
         full codepoint test
           0..65535 (1/2/3 byte sequences):
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/runner/work/1/s/out/common/input/TextDecoder.test.js)
      at processImmediate (internal/timers.js:464:21)
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Oct 6, 2022
@Tyriar Tyriar added this to the 5.1.0 milestone Oct 6, 2022
@Tyriar Tyriar self-assigned this Oct 6, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Oct 6, 2022

They're red when running locally:

      full codepoint test
        ✔ 0..65535 (1/2/3 byte sequences) (84ms)
        ✔ 65536..0x10FFFF (4 byte sequences) (858ms)
        ✔ 0xFEFF(BOM)

@jerch
Copy link
Member

jerch commented Oct 6, 2022

Well its actually a full range test for proper utf8-->utf32 conversion. No clue how to make it faster, maybe split in smaller parts? Note that timeout in azure basically means, that the test server are very packed with work (the test is only CPU bound). We can also skip the test unless someone does changes to the unit?

@Tyriar
Copy link
Member Author

Tyriar commented Oct 6, 2022

I'm splitting it into 10000 chunks atm which makes none of them warn about time, pr in a sec

Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants