Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double rendering is causing dropped frames #4225

Closed
Tyriar opened this issue Oct 21, 2022 · 0 comments · Fixed by #4226
Closed

Double rendering is causing dropped frames #4225

Tyriar opened this issue Oct 21, 2022 · 0 comments · Fixed by #4226
Assignees
@Tyriar
Labels
area/performance type/bug Something is misbehaving
Milestone
5.1.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 21, 2022

Xterm.js fake terminal, webgl is showing dropped frames:

Pasted image 20221021124445

This is happening due to an animation frame request inside an animation frame in buffer decoration code:

Pasted image 20221021124934
@Tyriar Tyriar added type/bug Something is misbehaving area/performance labels Oct 21, 2022
@Tyriar Tyriar added this to the 5.1.0 milestone Oct 21, 2022
@Tyriar Tyriar self-assigned this Oct 21, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Oct 21, 2022
@Tyriar
Fix dropped frame issue
8d4d5bd 
This ensures decorations are refreshed in the same frame when called from
an animation frame callback

Fixes xtermjs#4225
@Tyriar Tyriar mentioned this issue Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/performance type/bug Something is misbehaving
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fix dropped frame issue Tyriar/xterm.js
1 participant
@Tyriar