Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link underline should be the same as FG color #957

Closed
Tyriar opened this issue Sep 8, 2017 · 3 comments
Closed

Link underline should be the same as FG color #957

Tyriar opened this issue Sep 8, 2017 · 3 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 8, 2017

Regression introduced in #938

image

@peacefullatom
Copy link
Contributor

I'd like to grab this :)

@Tyriar
Copy link
Member Author

Tyriar commented Aug 21, 2018

@peacefullatom great! 😃

The link underlines are rendered from this file: https://github.com/xtermjs/xterm.js/blob/master/src/renderer/LinkRenderLayer.ts

You can check this code for how to get the foreground color:

let fg = (attr >> 9) & 0x1ff;

peacefullatom added a commit to peacefullatom/xterm.js that referenced this issue Aug 23, 2018
@peacefullatom
Copy link
Contributor

@Tyriar, thank you for hints, they were helpful!

This comment by @mofux was very informative as well.

If there is anything I can add/improve just tell me.

Cheers! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants