Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search addon for lines with emojis and wide chars #1211

Merged
merged 4 commits into from
Jan 24, 2018
Merged

Fix search addon for lines with emojis and wide chars #1211

merged 4 commits into from
Jan 24, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 16, 2018

Fixes #1103

@Tyriar Tyriar added this to the 3.1.0 milestone Jan 16, 2018
@Tyriar Tyriar self-assigned this Jan 16, 2018
@Tyriar Tyriar mentioned this pull request Jan 16, 2018
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jan 23, 2018

Ping @parisk @mofux

parisk
parisk approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

LGTM 👍

@Tyriar Tyriar merged commit 3798b28 into xtermjs:master Jan 24, 2018
@Tyriar Tyriar deleted the 1103_search_wide_emoji branch January 24, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @parisk