Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Terminal types from xterm.d.ts in Addons #1222

Merged
merged 3 commits into from
Jan 19, 2018
Merged

Use Terminal types from xterm.d.ts in Addons #1222

merged 3 commits into from
Jan 19, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 18, 2018 •
edited
Loading

Fixes #1220

@Tyriar Tyriar added this to the 3.1.0 milestone Jan 18, 2018
@Tyriar Tyriar self-assigned this Jan 18, 2018
@Tyriar Tyriar mentioned this pull request Jan 19, 2018
Merged
parisk
parisk approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I would just suggest rebasing with master before merging.

@Tyriar Tyriar merged commit d33c340 into xtermjs:master Jan 19, 2018
@Tyriar Tyriar deleted the 1220_addon_types branch January 19, 2018 17:34
@Tyriar Tyriar mentioned this pull request Jan 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @vincentwoo @parisk