Remove legacy .gitignore rules #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually maybe we do need dist still
What task builds the dist folder? |
parisk
previously requested changes
Jan 26, 2018
.gitignore
Outdated
| @@ -19,10 +19,5 @@ fixtures/typings-test/*.js | |||
| # Directories needed for code coverage | |||
| /coverage/ | |||
|
|
|||
| # Keep legacy files out of the repo, this can be removed when we merge v3 into master | |||
| dist/ | |||
There was a problem hiding this comment.
We need dist/ to keep the distribution files created by the following lines:
Lines 17 to 18 in 6c54c6c
There was a problem hiding this comment.
Ah, that's where it's done. Was there any reason we don't just move the build dir to dist?
There was a problem hiding this comment.
Created #1254 to follow this question up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@parisk we don't need the dist/ rule anymore right?