Remove didCharSizeChange logic from renderer #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only thing `didCharSizeChange` was used for was to figure out if we need to refresh the character atlas or not. However, `acquireCharAtlas` already inspects the atlas owned by this terminal, and if it matches, it avoids generating a new atlas. So if `didCharSizeChange` is true and it's not needed, it quickly bails out as a no-op. But if `didCharSizeChange` is false, and it was needed (possible given the complexity of testing all of these edge cases), it could introduce a bug. I think it makes sense to just get rid of `didCharSizeChange`, and just always call `acquireCharAtlas`.
|
@bgw I think this looks good, changing settings and resizing rarely happens anyway, the main concern was extra GCs that could be caused by I'll merge this in once 3.2.0 gets branched off. |
Tyriar
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing
didCharSizeChangewas used for was to figure out if weneed to refresh the character atlas or not. However,
acquireCharAtlasalready inspects the atlas owned by this terminal, and if it matches, it
avoids generating a new atlas.
So if
didCharSizeChangeis true and it's not needed, it quickly bailsout as a no-op. But if
didCharSizeChangeis false, and it was needed(possible given the complexity of testing all of these edge cases), it
could introduce a bug.
I think it makes sense to just get rid of
didCharSizeChange, and justalways call
acquireCharAtlas.