Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce upper case for public const/enum members and const #1407

Merged
merged 4 commits into from
Apr 24, 2018
Merged

Enforce upper case for public const/enum members and const #1407

merged 4 commits into from
Apr 24, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Apr 24, 2018 •
edited
Loading

Fixes #1406
Fixes #1408

@Tyriar Tyriar added this to the 3.4.0 milestone Apr 24, 2018
@Tyriar Tyriar self-assigned this Apr 24, 2018
@Tyriar Tyriar changed the title Enforce upper case for public const/enum members Enforce upper case for public const/enum members and const Apr 24, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Apr 24, 2018

Created ajafff/tslint-consistent-codestyle#67 to see why the rule ignores exports

bgw
bgw approved these changes Apr 24, 2018
View reviewed changes
Copy link
Member

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not?

@Tyriar
Copy link
Member Author

Tyriar commented Apr 24, 2018

@bgw I'm terrified

@Tyriar Tyriar merged commit 83fe87d into xtermjs:master Apr 24, 2018
@Tyriar Tyriar deleted the enum_names branch April 24, 2018 18:01
@Tyriar Tyriar mentioned this pull request Apr 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgw bgw bgw approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @bgw