Update README.md #1420
Merged
Update README.md #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the deprecated octal escapes with Unicode escapes. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Deprecated_octal
Tyriar
reviewed
Apr 27, 2018
README.md
Outdated
| @@ -41,7 +41,7 @@ To start using xterm.js on your browser, add the `xterm.js` and `xterm.css` to t | |||
| <script> | |||
| var term = new Terminal(); | |||
| term.open(document.getElementById('terminal')); | |||
| term.write('Hello from \033[1;3;31mxterm.js\033[0m $ ') | |||
| term.write('Hello from \u001B[1;3;31mxterm.js\u001B[0m $ ') | |||
There was a problem hiding this comment.
Interesting, didn't know they were deprecated. I tend to prefer hex escapes as they're a little more compact, can we do that instead? \x1b
|
@Tyriar updated |
|
@pro-src thanks! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1419
Replace the deprecated octal escapes with hex escapes.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Deprecated_octal