Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining naming conventions into tslint #1421

Merged
merged 7 commits into from
Jun 3, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Apr 26, 2018

I think that's everything 😄

The one that's commented out introduces a fair number of changes as it's inconsistent throughout the codebase. Let's defer that one for when there are less big PRs out.

@Tyriar Tyriar self-assigned this Apr 26, 2018
@Tyriar Tyriar added this to the 3.5.0 milestone May 21, 2018
@mofux
Copy link
Contributor

mofux commented Jun 3, 2018

LGTM 👍

@Tyriar Tyriar merged commit 3d56b15 into xtermjs:master Jun 3, 2018
@Tyriar Tyriar deleted the more_naming_conventions branch June 3, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants