Fix tsc #1445
Merged
Fix tsc #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgw
suggested changes
May 11, 2018
There was a problem hiding this comment.
Hey, thanks for taking a stab at fixing this. I think it'd be better for us to downgrade our dependency instead.
We need most of our code to be compatible with IE11 (to support this Visual Studio plugin), and excluding these libs helps ensure that's true.
|
@bgw, glad to help. I've set it to v6.0.108. |
|
Cool. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent build failures are due to @types/node being updated to v6.0.109 and is allowed by the semantic versioning in
package.json.DefinitelyTyped/DefinitelyTyped#25407 introduced the breaking change:
Iterablewas introducedIteratorwas introducedSymbol.iteratorwas used for the first timeIt's unclear to me whether this is a bug because, according to docs when targeting es5 and using es6 builtins, tsc should have been throwing errors. Although the es6 features that are being used worked fine with
@types/nodev6.0.108 and backward to the minimum version in xterm.js/package.json.The author of the aforementioned PR is asked about type
Iteratorin a review and it's explained that the type was copied from@types/nodev7. The PR was merged but perhaps they should've used typeIterableIterator???Anyways, maybe somebody with more TS knowledge will get some useful pointers from this PR.