Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer const vs let for variables that are only declared once #1477

Merged
merged 1 commit into from
May 30, 2018

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented May 30, 2018

Requires that variable declarations use const instead of let and var if possible: https://palantir.github.io/tslint/rules/prefer-const/

This is mostly for code readability, performance wins are debatable.

Requires that variable declarations use `const` instead of `let` and `var` if possible.

This is mostly for code readability, performance wins are debatable.
@Tyriar
Copy link
Member

Tyriar commented May 30, 2018

Love it! 😄

@Tyriar Tyriar added this to the 3.5.0 milestone May 30, 2018
@Tyriar Tyriar merged commit 4617bab into xtermjs:master May 30, 2018
@lgeiger lgeiger deleted the let-const branch May 30, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants