Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1532: 'Reset to Initial State' (RIS) escape sequence no longer makes the cursor disappear #1535

Merged
merged 3 commits into from
Jun 27, 2018
Merged

#1532: 'Reset to Initial State' (RIS) escape sequence no longer makes the cursor disappear #1535

merged 3 commits into from
Jun 27, 2018

Conversation

7PH
Copy link
Contributor

@7PH 7PH commented Jun 27, 2018

Following issue #1532

Here is the list of the modification I've made:

  • saved cursorState attribute before the reset then restored it after
  • added test case to ensure the value was not changed by the terminal reset

@Tyriar Tyriar added this to the 3.5.0 milestone Jun 27, 2018
Tyriar
Tyriar approved these changes Jun 27, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Tyriar Tyriar merged commit 8c20a2e into xtermjs:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@7PH @Tyriar