Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only sync viewport in an animation frame #1607

Merged
merged 3 commits into from
Sep 1, 2018
Merged

Only sync viewport in an animation frame #1607

merged 3 commits into from
Sep 1, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 9, 2018

Fixes #444 🎉 🎉 🎉

Before:

screen shot 2018-08-09 at 12 17 52 pm

After:

screen shot 2018-08-09 at 12 17 16 pm

@Tyriar Tyriar added this to the 3.7.0 milestone Aug 9, 2018
@Tyriar Tyriar self-assigned this Aug 9, 2018
jerch
jerch approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@jerch jerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and already showed nice savings while testing. 👍

@Tyriar Tyriar merged commit e2cfd94 into xtermjs:master Sep 1, 2018
@Tyriar Tyriar deleted the 444_viewport_sync branch September 1, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerch jerch jerch approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @jerch