Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with receive the result from FileReader #1619

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Bug with receive the result from FileReader #1619

merged 1 commit into from
Aug 21, 2018

Conversation

meefik
Copy link
Contributor

@meefik meefik commented Aug 18, 2018

The incorrect "this" variable must be replaced with "fileReader".

Incorrect variable "this" must be replace to fileReader.
@Tyriar
Copy link
Member

Tyriar commented Aug 19, 2018

Can you explain the bug? It does look like this is wrong but I'm not too familiar with this code and we use attach in the demo and I'm not sure what the problem is.

@meefik
Copy link
Contributor Author

meefik commented Aug 19, 2018

After call event 'load' we must be get result data from FileReader instance, in this case 'fileReader.result'. Please see the example https://developer.mozilla.org/en-US/docs/Web/API/FileReader/result#Example

@Tyriar Tyriar self-assigned this Aug 21, 2018
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😃

@Tyriar Tyriar added this to the 3.7.0 milestone Aug 21, 2018
@Tyriar Tyriar merged commit 01bfa1d into xtermjs:master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants